Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit tests to task package #273

Merged
merged 1 commit into from
Jun 30, 2017

Conversation

adshmh
Copy link
Contributor

@adshmh adshmh commented Jun 29, 2017

Added unit tests to task package, as part of work on #37.
Signed-off-by: Arash Deshmeh adeshmeh@ca.ibm.com

- What I did
Added unit tests to the cli/command/task package.

- How I did it
Added unit tests and test data to the cli/command/task package.

- How to verify it

  • Run the tests (make -f docker.Makefile test)
  • With this PR, the output will include:

=== RUN TestTaskPrintWithQuietOption
--- PASS: TestTaskPrintWithQuietOption (0.00s)
=== RUN TestTaskPrintWithNoTruncOption
--- PASS: TestTaskPrintWithNoTruncOption (0.00s)
=== RUN TestTaskPrintWithGlobalService
--- PASS: TestTaskPrintWithGlobalService (0.00s)
=== RUN TestTaskPrintWithReplicatedService
--- PASS: TestTaskPrintWithReplicatedService (0.00s)
=== RUN TestTaskPrintWithIndentation
--- PASS: TestTaskPrintWithIndentation (0.00s)
=== RUN TestTaskPrintWithResolution
--- PASS: TestTaskPrintWithResolution (0.00s)
PASS
ok github.com/docker/cli/cli/command/task 0.025s

- Description for the changelog
Added unit tests to cli/command/task package

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
@codecov-io
Copy link

codecov-io commented Jun 29, 2017

Codecov Report

Merging #273 into master will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
+ Coverage   46.98%   47.08%   +0.09%     
==========================================
  Files         172      173       +1     
  Lines       11693    11731      +38     
==========================================
+ Hits         5494     5523      +29     
- Misses       5882     5888       +6     
- Partials      317      320       +3

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐮

Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnephin dnephin merged commit 379b762 into docker:master Jun 30, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.07.0 milestone Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants