Commits on Mar 15, 2022

1. registry: don't call "/info" API endpoint to get default registry …

   The CLI currenly calls the `/info` endpoint to get the address
   of the default registry to use.
   
   This functionality was added as part of the initial Windows implementation
   of the engine. For legal reasons, Microsoft Windows (and thus Docker images
   based on Windows) were not allowed to be distributed through non-Microsoft
   infrastructure. As a temporary solution, a dedicated "registry-win-tp3.docker.io"
   registry was created to serve Windows images.
   
   As a result, the default registry was no longer "fixed", so a helper function
   (`ElectAuthServer`) was added to allow the CLI to get the correct registry
   address from the daemon. (docker/docker PR's/issues 18019, 19891, 19973)
   
   Using separate registries was not an ideal solution, and a more permanent
   solution was created by introducing "foreign image layers" in the distribution
   spec, after which the "registry-win-tp3.docker.io" ceased to exist, and
   removed from the engine through docker/docker PR 21100.
   
   However, the `ElectAuthServer` was left in place, quoting from that PR;
   
   > make the client check which default registry the daemon uses is still
   > more correct than leaving it up to the client, even if it won't technically
   > matter after this PR. There may be some backward compatibility scenarios
   > where `ElectAuthServer` [sic] is still helpful.
   
   That comment was 5 years ago, and given that the engine and cli are
   released in tandem, and the default registry is not configurable, we
   can save the extra roundtrip to the daemon by using a fixed value.
   
   This patch deprecates the `ElectAuthServer` function, and makes it
   return the default registry without calling (potentially expensie)
   `/info` API endpoint.
   
   Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

   

   thaJeztah committed Mar 15, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for b4ca1c7
   • Browse repository at this point

   Copy the full SHA

   b4ca1c7 View commit details

   Browse the repository at this point in the history