[20.10 backport] Fix panic when failing to get DefaultAuthConfig #2959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit f32731f fixed a potential panic when an error was returned while trying to get existing credentials. However, other code paths currently use the result of `GetDefaultAuthConfig()` even in an error condition; this resulted in a panic, because a `nil` was returned. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit c2820a7) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report
@@ Coverage Diff @@
## 20.10 #2959 +/- ##
==========================================
- Coverage 57.02% 57.00% -0.02%
==========================================
Files 297 297
Lines 18666 18668 +2
==========================================
- Hits 10644 10642 -2
- Misses 7157 7160 +3
- Partials 865 866 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #2918
fixes #2890 Non-root user "docker login" results in panic SIGSEGV segmentation violation
fixes moby/moby#41771 Command 'docker login' does not work
Commit f32731f (#2818) fixed a potential panic when an error was returned while trying to get existing credentials.
However, other code paths currently use the result of
GetDefaultAuthConfig()even in an error condition; this resulted in a panic, because anilwas returned.We should fix the other code paths to be more resilient, and to not use the result of
GetDefaultAuthConfig()if an error occurs, but starting with a minimal patch to fix the immediate issue.- Description for the changelog