Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stack output stream #298

Merged
merged 2 commits into from
Jul 10, 2017
Merged

Conversation

dnephin
Copy link
Contributor

@dnephin dnephin commented Jul 5, 2017

Fixes moby/moby#33954

"Nothing found in stack" should go to stderr

Also cleaned up some duplication in task format selection

dnephin added 2 commits July 5, 2017 13:32
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
@codecov-io
Copy link

codecov-io commented Jul 5, 2017

Codecov Report

Merging #298 into master will decrease coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
- Coverage   48.93%   48.92%   -0.01%     
==========================================
  Files         177      177              
  Lines       11846    11840       -6     
==========================================
- Hits         5797     5793       -4     
  Misses       5687     5687              
+ Partials      362      360       -2

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

ping @vdemeester PTAL

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@vdemeester vdemeester merged commit af6c089 into docker:master Jul 10, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.07.0 milestone Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants