using nature sort secrets and configs in cli #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allencloud
force-pushed
the
sort-secrets-and-configs-in-cli
branch
3 times, most recently
from
ba45d68 to
314fe55
Compare
|
Although some tests do need to be updated |
allencloud
force-pushed
the
sort-secrets-and-configs-in-cli
branch
2 times, most recently
from
a569689 to
c073bb9
Compare
|
I think this should use the "natural sort" like #302. ping @ripcurld0 |
|
Thanks for your feedback, I will do a change. @aaronlehmann |
|
hmm, not sure why that is. Maybe cirlceci was having issues? Have you setup circleci on your fork? I think that can cause problems sometimnes |
|
@allencloud This PR needs to be rebased |
allencloud
force-pushed
the
sort-secrets-and-configs-in-cli
branch
from
c073bb9 to
45e2ae1
Compare
allencloud
force-pushed
the
sort-secrets-and-configs-in-cli
branch
2 times, most recently
from
22c7fb8 to
dea4565
Compare
|
CI is failing |
|
Thanks for your feedback. @aaronlehmann |
|
@allencloud ping 👼 |
allencloud
force-pushed
the
sort-secrets-and-configs-in-cli
branch
7 times, most recently
from
996824e to
886ebbc
Compare
allencloud
changed the title
allencloud
force-pushed
the
sort-secrets-and-configs-in-cli
branch
from
886ebbc to
5105e0e
Compare
allencloud
force-pushed
the
sort-secrets-and-configs-in-cli
branch
3 times, most recently
from
d25f04b to
48398ee
Compare
Signed-off-by: Allen Sun <shlallen1990@gmail.com>
allencloud
force-pushed
the
sort-secrets-and-configs-in-cli
branch
from
48398ee to
26f06c5
Compare
Codecov Report
@@ Coverage Diff @@
## master #307 +/- ##
==========================================
+ Coverage 49.22% 49.26% +0.04%
==========================================
Files 200 200
Lines 16453 16465 +12
==========================================
+ Hits 8099 8112 +13
+ Misses 7934 7933 -1
Partials 420 420 |
|
Sorry for the delay. And I have updated this PR to use natural sort to sort docker cli config/secret ls output. PTAL @dnephin @aaronlehmann @vdemeester |
jeanlaurent
pushed a commit
to jeanlaurent/cli
that referenced
this pull request
Sep 25, 2017
…s-in-cli using nature sort secrets and configs in cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: allencloud allen.sun@daocloud.io
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)