context: deprecate support for encrypted TLS private keys #3218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thaJeztah this PR needs to be rebased on top of |
|
oh! 🤦 no it's because I deprecated the |
> Legacy PEM encryption as specified in RFC 1423 is insecure by design. Since > it does not authenticate the ciphertext, it is vulnerable to padding oracle > attacks that can let an attacker recover the plaintext From https://go-review.googlesource.com/c/go/+/264159 > It's unfortunate that we don't implement PKCS#8 encryption so we can't > recommend an alternative but PEM encryption is so broken that it's worth > deprecating outright. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
deprecate_encrypted_tls
branch
from
1808046 to
15535d4
Compare
Codecov Report
@@ Coverage Diff @@
## master #3218 +/- ##
==========================================
- Coverage 58.58% 58.57% -0.01%
==========================================
Files 299 299
Lines 21502 21502
==========================================
- Hits 12597 12595 -2
- Misses 7983 7984 +1
- Partials 922 923 +1 |
|
Whoop; it's green now @silvin-lubecki ptal |
silvin-lubecki
approved these changes
Jul 28, 2021
This was referenced Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #3212
follow-up to #3213
From https://go-review.googlesource.com/c/go/+/264159
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)