Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filters displaying for docker search #331

Merged
merged 1 commit into from
Jul 15, 2017

Conversation

yuexiao-wang
Copy link
Contributor

Signed-off-by: yuexiao-wang wang.yuexiao@zte.com.cn

Fixes #330

- What I did

  1. Use "boolean - true or false" instead of "true|false"
  2. Remove some blank line

- How to verify it
issue #330

@yuexiao-wang
Copy link
Contributor Author

Why validate CI is failed?

@yuexiao-wang
Copy link
Contributor Author

@dnephin PTAL

@dnephin
Copy link
Contributor

dnephin commented Jul 13, 2017

This validate failure is fixed on master, if you rebase with the latest master it should be fixed.

@codecov-io
Copy link

codecov-io commented Jul 14, 2017

Codecov Report

Merging #331 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
+ Coverage   48.84%   48.85%   +<.01%     
==========================================
  Files         186      186              
  Lines       12413    12413              
==========================================
+ Hits         6063     6064       +1     
+ Misses       5976     5975       -1     
  Partials      374      374

@yuexiao-wang yuexiao-wang force-pushed the docker-search-filters branch from 19c69df to bd64ad2 Compare July 14, 2017 00:48
Signed-off-by: yuexiao-wang <wang.yuexiao@zte.com.cn>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants