Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bash completion for --storage-opt dm.libdm_log_level #334

Merged

Conversation

albers
Copy link
Collaborator

@albers albers commented Jul 14, 2017

This adds bash completion for moby/moby#33845.
See also documentation PR #324.

This adds bash completion for moby/moby#33845.

Signed-off-by: Harald Albers <github@albersweb.de>
@codecov-io
Copy link

Codecov Report

Merging #334 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #334   +/-   ##
=======================================
  Coverage   48.85%   48.85%           
=======================================
  Files         186      186           
  Lines       12413    12413           
=======================================
  Hits         6064     6064           
  Misses       5975     5975           
  Partials      374      374

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@albers
Copy link
Collaborator Author

albers commented Jul 26, 2017

This should go into 17.07.0 because the feature is present in that release.

Copy link
Contributor

@mlaventure mlaventure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlaventure mlaventure merged commit 68c27d7 into docker:master Aug 2, 2017
@albers albers deleted the completion--storage-opt-dm.libdm_log_level branch August 2, 2017 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants