Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: github actions validate workflow #3381

Merged
merged 6 commits into from
Feb 25, 2022
Merged

ci: github actions validate workflow #3381

merged 6 commits into from
Feb 25, 2022

Conversation

crazy-max
Copy link
Member

follow-up #3365

Switch to GitHub Actions for validate target:

  • authors
  • vendor
  • yamldocs
  • manpages

Bake targets have also been added for each of them so we only need to set targets to the current matrix in the validate GHA workflow.

CircleCI is now removed. In a follow-up we could fix:

  • cli/.github/workflows/test.yml

    Line 45 in 4db5a4f

    # - windows-latest # FIXME: some tests are failing on the Windows runner, as well as on Appveyor since June 24, 2018: https://ci.appveyor.com/project/docker/cli/history

  • cli/.github/workflows/e2e.yml

    Lines 27 to 28 in 4db5a4f

    # - 20.10-dind # FIXME: Fails on 20.10
    - stable-dind # TODO: Use 20.10-dind, stable-dind is deprecated

Open questions:

  • Switch to cli-docs-tool for yaml docs generation but we can pick that commit in a follow-up if you prefer. For man pages generation with cli-docs-tool, needs to work on Man support cli-docs-tool#14 first.
  • Some Dockerfiles have been added but we might be able to merge them to the Dockerfile.dev one.
  • de8d569 was added to have an unique place to set the GO_VERSION but this would enforce buildx bake usage.

@crazy-max
Copy link
Member Author

image

This check fails because CircleCI config has been removed.

image

When this PR is merged we should remove the CircleCI integration in this repository.

@crazy-max crazy-max marked this pull request as ready for review December 9, 2021 10:15
@crazy-max crazy-max force-pushed the gha-validate branch 2 times, most recently from 0097b27 to 910979d Compare January 13, 2022 14:49
thaJeztah
thaJeztah reviewed Jan 13, 2022
View reviewed changes
vendor.mod Outdated Show resolved Hide resolved
@crazy-max crazy-max force-pushed the gha-validate branch 3 times, most recently from e6134bf to 5127f8f Compare January 14, 2022 08:06
@crazy-max crazy-max force-pushed the gha-validate branch 7 times, most recently from f10b743 to 5b1ae5d Compare January 18, 2022 16:18
@crazy-max
Copy link
Member Author

PTAL @thaJeztah @silvin-lubecki

@crazy-max crazy-max mentioned this pull request Jan 27, 2022
Closed
@crazy-max crazy-max force-pushed the gha-validate branch 7 times, most recently from c3efe6f to 3b6ee0d Compare January 27, 2022 20:11
@crazy-max crazy-max force-pushed the gha-validate branch 2 times, most recently from d757a2c to 554489b Compare January 28, 2022 17:53
@crazy-max
add common args bake target
ede3274 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max
validate authors target
bea6c0d 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max
fix inherits for vendor bake defs
76a2a19 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max
switch to cli-docs-tool for yaml docs generation
a650f4d 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
switch to cli-docs-tool and validate yamldocs

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max
validate manpages target
7dc35c0 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max
remove circleci
f160fd3 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
thaJeztah
thaJeztah approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

circle-ci failure is expected (as it's removed in this PR); we could've keep it in this one, and remove after, but probably not worth the hassle

@thaJeztah thaJeztah added area/testing kind/refactor PR's that refactor, or clean-up code status/2-code-review labels Feb 25, 2022
@thaJeztah thaJeztah added this to the 21.xx milestone Feb 25, 2022
silvin-lubecki
silvin-lubecki approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

okay... here we go!

@thaJeztah thaJeztah merged commit 6401786 into docker:master Feb 25, 2022
@crazy-max crazy-max deleted the gha-validate branch February 25, 2022 18:46
@crazy-max crazy-max mentioned this pull request Feb 25, 2022
Merged
@cyphar cyphar mentioned this pull request Apr 18, 2023
Open
@cyphar cyphar mentioned this pull request Apr 26, 2023
Open
@tianon tianon mentioned this pull request May 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvin-lubecki silvin-lubecki silvin-lubecki approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees
No one assigned
Labels
area/testing kind/refactor PR's that refactor, or clean-up code status/2-code-review
Projects
None yet
Milestone
23.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@crazy-max @thaJeztah @silvin-lubecki