Sort services names in a natural order #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #357 +/- ##
==========================================
+ Coverage 45.47% 45.78% +0.31%
==========================================
Files 193 193
Lines 16061 16065 +4
==========================================
+ Hits 7304 7356 +52
+ Misses 8379 8323 -56
- Partials 378 386 +8 |
dnephin
reviewed
Jul 19, 2017
cli/command/service/list_test.go
Outdated
| "github.com/docker/docker/api/types" | ||
| "github.com/docker/docker/api/types/swarm" | ||
| "github.com/docker/docker/pkg/testutil" | ||
| "github.com/moby/moby/pkg/testutil/golden" |
There was a problem hiding this comment.
docker/docker/pkg/testutil/golden
cli/command/service/list_test.go
Outdated
|
|
||
| func TestServiceListOrder(t *testing.T) { | ||
| buf := new(bytes.Buffer) | ||
| cli := test.NewFakeCliWithOutput(&fakeClient{ |
There was a problem hiding this comment.
NewFakeCliWithOutput is deprecated. Please use NewFakeCli(). It defaults to an output buffer.
You can get the buffer from cli.OutBuffer()
Signed-off-by: Boaz Shuster <ripcurld.github@gmail.com>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #315
@aaronlehmann Let me know if there are other resources that need to be natural-sorted.
- What I did
Use natural sorting to display swarm services
- How I did it
Using the
sortorder.NaturalLessfunction and theSortinterface- How to verify it