vendor: gotest.tools/v3 v3.5.0 #4469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- go.mod: update dependencies and go version by - Use Go1.20 - Fix couple of typos - Added `WithStdout` and `WithStderr` helpers - Moved `cmdOperators` handling from `RunCmd` to `StartCmd` - Deprecate `assert.ErrorType` - Remove outdated Dockerfile - add godoc links full diff: gotestyourself/gotest.tools@v3.4.0...v3.5.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Jul 29, 2023
Comment on lines
+120
to
+123
| # FIXME temporarily suppress these (see https://github.com/gotestyourself/gotest.tools/issues/272) | ||
| - text: "SA1019: (assert|cmp|is)\\.ErrorType is deprecated" | ||
| linters: | ||
| - staticcheck |
There was a problem hiding this comment.
Temporarily suppressing deprecation warnings, pending:
1 task
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4469 +/- ##
=======================================
Coverage 59.39% 59.39%
=======================================
Files 288 288
Lines 24782 24782
=======================================
Hits 14720 14720
Misses 9175 9175
Partials 887 887 |
This was referenced Jul 29, 2023
|
Thx! I'll bring this one in, and rebase the containerd vendor PR |
|
DOH! Mixed up PR's thought this was the one in moby... well... 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WithStdoutandWithStderrhelperscmdOperatorshandling fromRunCmdtoStartCmdassert.ErrorTypefull diff: gotestyourself/gotest.tools@v3.4.0...v3.5.0
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)