Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update host-gateway-ip to use daemon.json instead of cli flag #4818

Merged

Conversation

dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Jan 23, 2024

Signed-off-by: David Karlsson 35727626+dvdksn@users.noreply.github.com

- What I did

Changes the host-gateway-ip example to use daemon.json config instead of cli flag.

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@dvdksn dvdksn requested a review from thaJeztah as a code owner January 23, 2024 13:13
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2024

Codecov Report

Merging #4818 (ec0a624) into master (c89975d) will decrease coverage by 0.42%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4818      +/-   ##
==========================================
- Coverage   59.63%   59.22%   -0.42%     
==========================================
  Files         287      285       -2     
  Lines       24777    24770       -7     
==========================================
- Hits        14775    14669     -106     
- Misses       9114     9213      +99     
  Partials      888      888              

@dvdksn dvdksn force-pushed the docs-dockerd-host-gateway-ip-daemonconfig branch from 06b5db9 to b82ce7d Compare January 23, 2024 14:45
@dvdksn dvdksn requested a review from thaJeztah January 23, 2024 14:45
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn dvdksn force-pushed the docs-dockerd-host-gateway-ip-daemonconfig branch from b82ce7d to ec0a624 Compare January 23, 2024 14:46
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

can you also open a cherry-pick for the 25.0 release branch?

@thaJeztah thaJeztah merged commit 1e8555a into docker:master Jan 23, 2024
77 checks passed
@dvdksn dvdksn deleted the docs-dockerd-host-gateway-ip-daemonconfig branch January 23, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants