-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[25.0 backport] update CI #4915
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 25.0 #4915 +/- ##
=======================================
Coverage 61.35% 61.35%
=======================================
Files 287 287
Lines 20088 20088
=======================================
Hits 12324 12324
Misses 6870 6870
Partials 894 894 |
Need to backport #4873 as well |
Allow tests to check the negotiated API version used by the client. Can be used to skip tests based on API versions, for example: ```go skip.If(t, versions.LessThan(environment.DaemonAPIVersion(t), "1.44")) ``` will skip the test if the API version is older than 1.44 Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> (cherry picked from commit 9831fea) Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
- gha runners updated to ubuntu 22.04 - e2e now runs against moby 23.0, 24.0 and 25.0 - temporarily skip broken test for moby < 25 Signed-off-by: Christopher Petito <chrisjpetito@gmail.com> (cherry picked from commit 6b67b95) Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Christopher Petito <chrisjpetito@gmail.com> (cherry picked from commit 69ed658) Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
backport: update CI #4839
backport: testenv: Add DaemonAPIVersion helper #4873
supersedes / closes gha: update runners to Ubuntu 22.04 #4793
supersedes / closes e2e: update engine version #3128
supersedes / closes ci/e2e: Run e2e for 24.0 and 25.0 engine #4822
- What I did
ubuntu-22.04
23-dind
,24-dind
and25-dind
versions of the engine- How I did it
magic
- How to verify it
CI tests are green
- A picture of a cute animal (not mandatory but encouraged)
TBD