-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set CGO_ENABLED=1 on riscv64 #4933
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4933 +/- ##
==========================================
- Coverage 61.42% 61.41% -0.01%
==========================================
Files 289 289
Lines 20237 20237
==========================================
- Hits 12431 12429 -2
- Misses 6904 6905 +1
- Partials 902 903 +1 |
Looks like it's segfaulting (possibly due to clang being used?)
|
Weird... TBH I don't have much knowledge about |
#4937 should fix this issue |
CGO works fine on riscv64 thus should be enabled. Avoid build error golang/go#64875 Signed-off-by: Zhuo Zhi <h.dwwwwww@gmail.com>
Rebased. Could anyone approve the CI? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- What I did
Set CGO_ENABLED=1 on riscv64
CGO works fine on riscv64 thus should be enabled.
Avoid build error golang/go#64875
- How I did it
Add riscv64 case in
scripts/build/.variables
- How to verify it
Arch Linux PKGBUILD doesn't build on riscv64, as it uses
-buildmode=pie
andscripts/build/.variables
setsCGO_ENABLED=0
before the PR.With this PR, it builds fine.
- Description for the changelog
Set CGO_ENABLED=1 on riscv64
- A picture of a cute animal (not mandatory but encouraged)