Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/image/tree: refactor #5572

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

laurazard
Copy link
Member

- What I did

Just some refactors to the image tree formatting logic to make reuse/reading easier. Consolidates the printing in one place, and reduces how far down we need to pass our writer.

This also makes testing these functions less involved.

- How I did it

(wip, I need to push more commits)

Make most of the formatting functions return strings, instead of printing directly.

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 195 lines in your changes missing coverage. Please review.

Project coverage is 59.55%. Comparing base (da9e984) to head (6c86dcc).
Report is 34 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5572      +/-   ##
==========================================
+ Coverage   59.15%   59.55%   +0.39%     
==========================================
  Files         342      346       +4     
  Lines       29079    29119      +40     
==========================================
+ Hits        17203    17341     +138     
+ Misses      10901    10808      -93     
+ Partials      975      970       -5     

Signed-off-by: Laura Brehm <laurabrehm@hey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants