vendor: github.com/docker/docker e5c2b5e10d68 (master, v28.0.0-dev) #5638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
full diff: moby/moby@6ac445c...e5c2b5e Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Nov 20, 2024
Comment on lines
+81
to
+82
| // TODO(thaJeztah): change flag-type to support multiple platforms. | ||
| options.Platforms = append(options.Platforms, p) |
There was a problem hiding this comment.
Some follow-ups will come to allow the flag to be used multiple times. The daemon does not yet support that, but we can already prepare the CLI for it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5638 +/- ##
=======================================
Coverage 59.49% 59.49%
=======================================
Files 346 346
Lines 29371 29371
=======================================
Hits 17474 17474
Misses 10922 10922
Partials 975 975
|
krissetto
approved these changes
Nov 20, 2024
Benehiko
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
full diff: moby/moby@6ac445c...e5c2b5e
- A picture of a cute animal (not mandatory but encouraged)