docs, man: remove confusing example for "--isolation" #5718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This snippet was added in [docker/cli@38ec5d8][1]. The intent was to indicate that an empty value is equivalent to passing "default" as value. However, passing the `--isolation` flag _without a value_ (i.e., no `=` specified) will fail in many cases, as any string after it will be parsed as value (e.g. `docker run --isolation busybox` would consider `busybox` as value). This patch removes these lines as they add more confusion than addressing. [1]: moby/moby@38ec5d8 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5718 +/- ##
=======================================
Coverage 59.52% 59.52%
=======================================
Files 346 346
Lines 29381 29381
=======================================
Hits 17488 17488
Misses 10923 10923
Partials 970 970 |
Benehiko
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--isolationmoby/moby#17822This snippet was added in docker@38ec5d8. The intent was to indicate that an empty value is equivalent to passing "default" as value. However, passing the
--isolationflag without a value (i.e., no=specified) will fail in many cases, as any string after it will be parsed as value (e.g.docker run --isolation busyboxwould considerbusyboxas value).This patch removes these lines as they add more confusion than addressing.
- A picture of a cute animal (not mandatory but encouraged)