Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reference docs: fix missing link from heading #5841

Merged

Conversation

sarahsanders-docker
Copy link
Contributor

@sarahsanders-docker sarahsanders-docker commented Feb 18, 2025

- What I did

If this is not the correct way to fix this, let me know!

- A picture of a cute animal (not mandatory but encouraged)
My cat Bean basking in sunlight
IMG_4104

@sarahsanders-docker sarahsanders-docker marked this pull request as ready for review February 18, 2025 19:50
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.16%. Comparing base (1dcfd23) to head (f977b92).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5841   +/-   ##
=======================================
  Coverage   59.16%   59.16%           
=======================================
  Files         352      352           
  Lines       29567    29567           
=======================================
  Hits        17493    17493           
  Misses      11092    11092           
  Partials      982      982           

@thaJeztah
Copy link
Member

Oh! And looks like the commit message is missing a "DCO" sign off line; hold on, I have a canned reply for thad (I'm on my phone 🥹)

@thaJeztah
Copy link
Member

Thank you for contributing! It appears your commit message is missing a DCO sign-off,
causing the DCO check to fail.

We require all commit messages to have a Signed-off-by line with your name
and e-mail (see "Sign your work"
in the CONTRIBUTING.md in this repository), which looks something like:

Signed-off-by: YourFirsName YourLastName <yourname@example.org>

There is no need to open a new pull request, but to fix this (and make CI pass),
you need to amend the commit(s) in this pull request, and "force push" the amended
commit.

Unfortunately, it's not possible to do so through GitHub's web UI, so this needs
to be done through the git commandline.

You can find some instructions in the output of the DCO check (which can be found
in the "checks" tab on this pull request), as well as in the Moby contributing guide.

Steps to do so "roughly" come down to:

  1. Set your name and e-mail in git's configuration:

    git config --global user.name "YourFirstName YourLastName"
    git config --global user.email "yourname@example.org"

    (Make sure to use your real name (not your GitHub username/handle) and e-mail)

  2. Clone your fork locally

  3. Check out the branch associated with this pull request

  4. Sign-off and amend the existing commit(s)

    git commit --amend --no-edit --signoff

    If your pull request contains multiple commits, either squash the commits (if
    needed) or sign-off each individual commit.

  5. Force push your branch to GitHub (using the --force or --force-with-lease flags) to update the pull request.

Sorry for the hassle (I wish GitHub would make this a bit easier to do), and let me know if you need help or more detailed instructions!

@sarahsanders-docker
Copy link
Contributor Author

All good @thaJeztah that is on me!!

Update name to dispatcher-heartbeat

Signed-off-by: Sarah Sanders <sarah.sanders@docker.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

looks like the markdown had to be regenerated, so I did a quick fix-up of that; thanks!

@thaJeztah thaJeztah merged commit 96eb1e9 into docker:master Feb 19, 2025
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants