-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reference docs: fix missing link from heading #5841
reference docs: fix missing link from heading #5841
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5841 +/- ##
=======================================
Coverage 59.16% 59.16%
=======================================
Files 352 352
Lines 29567 29567
=======================================
Hits 17493 17493
Misses 11092 11092
Partials 982 982 |
Oh! And looks like the commit message is missing a "DCO" sign off line; hold on, I have a canned reply for thad (I'm on my phone 🥹) |
Thank you for contributing! It appears your commit message is missing a DCO sign-off, We require all commit messages to have a
There is no need to open a new pull request, but to fix this (and make CI pass), Unfortunately, it's not possible to do so through GitHub's web UI, so this needs You can find some instructions in the output of the DCO check (which can be found Steps to do so "roughly" come down to:
Sorry for the hassle (I wish GitHub would make this a bit easier to do), and let me know if you need help or more detailed instructions! |
5438ad8
to
108a266
Compare
All good @thaJeztah that is on me!! |
556e31c
to
1add3eb
Compare
Update name to dispatcher-heartbeat Signed-off-by: Sarah Sanders <sarah.sanders@docker.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
1add3eb
to
f977b92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
looks like the markdown had to be regenerated, so I did a quick fix-up of that; thanks!
- What I did
name="configure-node-healthcheck-frequency---dispatcher-heartbeat"
to headingIf this is not the correct way to fix this, let me know!
- A picture of a cute animal (not mandatory but encouraged)

My cat Bean basking in sunlight