[28.x backport] cli/command: deprecate DockerCli.Apply #6497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Apply method was added when CLI options for constructing the CLI were rewritten into functional options in [cli@7f207f3]. There was no mention in the pull request of this method specifically, and this may have been related to work being done elsewhere on compose-on-kubernetes or the compose-cli plugin that may have needed options to modify the CLI config after it was already initialized. The CLI itself no longer depends on this method since [cli@133279f], and the only known consumer (docker compose) no longer needs it since [cli@2711800] and [cli@048e931]. This patch deprecates the method with the intent to remove it in a future release. [cli@7f207f3]: docker@7f207f3 [cli@133279f]: docker@133279f [cli@2711800]: docker@2711800 [cli@048e931]: docker@048e931 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 24bfedf) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
impact/changelog
impact/deprecation
status/2-code-review
kind/refactor
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
vvoland
approved these changes
Sep 25, 2025
jakobmoellerdev
pushed a commit
to open-component-model/ocm
that referenced
this pull request
Oct 8, 2025
<!-- markdownlint-disable MD041 --> #### What this PR does / why we need it The PR removes the usage of the deprecated `DockerCli.Apply`. See also: docker/cli#6497 #### Which issue(s) this PR is related to This PR is a prerequisite for #1634. Signed-off-by: Ilya Khandamirov <ilya.khandamirov@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to:
cli/command: deprecate DockerCli.Apply
The Apply method was added when CLI options for constructing the CLI were rewritten into functional options in cli@7f207f3. There was no mention in the pull request of this method specifically, and this may have been related to work being done elsewhere on compose-on-kubernetes or the compose-cli plugin that may have needed options to modify the CLI config after it was already initialized.
The CLI itself no longer depends on this method since cli@133279f, and the only known consumer (docker compose) no longer needs it since cli@2711800 and cli@048e931.
This patch deprecates the method with the intent to remove it in a future release.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)