-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bash completion for --platform
#704
Conversation
Codecov Report
@@ Coverage Diff @@
## master #704 +/- ##
==========================================
- Coverage 51.81% 51.81% -0.01%
==========================================
Files 218 218
Lines 17924 17924
==========================================
- Hits 9288 9287 -1
- Misses 8160 8161 +1
Partials 476 476 |
--publish
--platform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes LGTM, but can you update the commit description (you accidentally typed --publish
instead of --platform
😄 )
32cda5b
to
3878bf3
Compare
Signed-off-by: Harald Albers <github@albersweb.de>
3878bf3
to
15f7841
Compare
Thanks for catching 😅! |
@thaJeztah By the way, I got CI errors on #713 and #717 that survived several forced pushes, probably caused by
Do you know how I could get rid of these? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐮
@thaJeztah The CI errors I asked you to look into are now gone after I rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh! thanks for the ping
LGTM
This adds bash completion for #474.
The completion is only added when commands are run against a daemon running in experimental mode.