Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bash completion for --platform #704

Merged
merged 1 commit into from
Dec 4, 2017

Conversation

albers
Copy link
Collaborator

@albers albers commented Nov 20, 2017

This adds bash completion for #474.
The completion is only added when commands are run against a daemon running in experimental mode.

@albers albers added this to the 17.12.0 milestone Nov 20, 2017
@codecov-io
Copy link

codecov-io commented Nov 20, 2017

Codecov Report

Merging #704 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #704      +/-   ##
==========================================
- Coverage   51.81%   51.81%   -0.01%     
==========================================
  Files         218      218              
  Lines       17924    17924              
==========================================
- Hits         9288     9287       -1     
- Misses       8160     8161       +1     
  Partials      476      476

@thaJeztah thaJeztah changed the title Add bash completion for --publish Add bash completion for --platform Nov 29, 2017
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM, but can you update the commit description (you accidentally typed --publish instead of --platform 😄 )

Signed-off-by: Harald Albers <github@albersweb.de>
@albers
Copy link
Collaborator Author

albers commented Nov 30, 2017

can you update the commit description (you accidentally typed --publish instead of --platform 😄 )

Thanks for catching 😅!
Fixed and rebased (there was a conflict with --stream from #678).

@albers
Copy link
Collaborator Author

albers commented Nov 30, 2017

@thaJeztah By the way, I got CI errors on #713 and #717 that survived several forced pushes, probably caused by

Could not update commit status. Message: Server returned HTTP response code: 201, message: 'Created' for URL: https://api.github.com/repos/docker/cli/statuses/9f5fb24854a578bcd9b778ff688efb9381efb68e

Do you know how I could get rid of these?

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐮

@albers
Copy link
Collaborator Author

albers commented Nov 30, 2017

@thaJeztah The CI errors I asked you to look into are now gone after I rebased.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh! thanks for the ping

LGTM

@thaJeztah thaJeztah merged commit 83cdc0f into docker:master Dec 4, 2017
@albers albers deleted the completion--platform branch December 5, 2017 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants