Remove aliases for orchestrator #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefer "strict" values for orchestrator, as it's easier to add aliases (if we think it's needed) than to remove them later. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report
@@ Coverage Diff @@
## master #803 +/- ##
======================================
Coverage 50.9% 50.9%
======================================
Files 237 237
Lines 15338 15338
======================================
Hits 7808 7808
Misses 7028 7028
Partials 502 502 |
There was a problem hiding this comment.
LGTM, sorry @thaJeztah I interpreted it as "remove the case insensitive matcher", and not "remove all aliases" 😄
|
No worries; I thought that was the case; also was a bit in doubt between using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer "strict" values for orchestrator, as it's easier to add aliases (if we think it's needed) than to remove them later.
I commented on this in my review on #721 (comment), but looks like we forgot to actually make that change.
ping @vdemeester @silvin-lubecki PTAL
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)