Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc guidance to only use 256 IPs per overlay #851

Merged
merged 1 commit into from
Feb 1, 2018
Merged

Doc guidance to only use 256 IPs per overlay #851

merged 1 commit into from
Feb 1, 2018

Conversation

mdlinville
Copy link
Contributor

Fixes docker/docs#5853

Overlay networks lose stability with more than 256 IPs, due to moby/moby#30820

We had some inconsistency between narrative docs and the CLI ref. This fixes that.

cc/ @mavenugo

baby squirrel

Signed-off-by: Misty Stanley-Jones <misty@docker.com>
@codecov-io
Copy link

codecov-io commented Jan 30, 2018

Codecov Report

Merging #851 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #851      +/-   ##
==========================================
- Coverage   52.93%   52.92%   -0.01%     
==========================================
  Files         245      245              
  Lines       15848    15848              
==========================================
- Hits         8389     8388       -1     
- Misses       6905     6906       +1     
  Partials      554      554

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@vdemeester vdemeester merged commit 19e4389 into docker:master Feb 1, 2018
@GordonTheTurtle GordonTheTurtle added this to the 18.03.0 milestone Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent overlay network size limits
5 participants