Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a non-zero timeout for HTTP client communication with plugin backend. #883

Merged
merged 1 commit into from
Feb 16, 2018

Conversation

anusha-ragunathan
Copy link
Contributor

Currently, the timeout is set to 0, which means no timeout. Set it to a
sane default timeout of 30 seconds.

Signed-off-by: Anusha Ragunathan anusha.ragunathan@docker.com

backend.

Currently, the timeout is set to 0, which means no timeout. Set it to a
sane default timeout of 30 seconds.

Signed-off-by: Anusha Ragunathan <anusha.ragunathan@docker.com>
@codecov-io
Copy link

codecov-io commented Feb 16, 2018

Codecov Report

Merging #883 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #883   +/-   ##
=======================================
  Coverage   52.73%   52.73%           
=======================================
  Files         257      257           
  Lines       16404    16404           
=======================================
  Hits         8650     8650           
  Misses       7183     7183           
  Partials      571      571

Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83 cpuguy83 merged commit a0044ba into docker:master Feb 16, 2018
@GordonTheTurtle GordonTheTurtle added this to the 18.03.0 milestone Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants