-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump moby vendor and dependencies #892
Conversation
- Add API support for SCTP port mapping - Add canonical import path - Add `REMOVE` and `ORPHANED` to TaskState - Fix TLS from environment variables in client - Introduce NewClientWithOpts func to build custom client easily - Wrap response errors for container copy methodsto fix error detection using `IsErrNotFound` and `IsErrNotImplemented` for `ContainerStatPath`, `CopyFromContainer`, and `CopyToContainer` methods. - Produce errors when empty ids are passed into inspect calls Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- Support parsing SCTP port mapping Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🦁
Looks like CircleCI is having some problems starting (some of) the tests. |
I don't have access to trigger a rebuild in Circle. |
Codecov Report
@@ Coverage Diff @@
## master #892 +/- ##
======================================
Coverage 53.2% 53.2%
======================================
Files 258 258
Lines 16338 16338
======================================
Hits 8693 8693
Misses 7080 7080
Partials 565 565 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
REMOVE
andORPHANED
to TaskState AddREMOVE
andORPHANED
to TaskState moby/moby#36146IsErrNotFound
andIsErrNotImplemented
forContainerStatPath
,CopyFromContainer
, andCopyToContainer
methods. Wrap response errors for container copy methods. moby/moby#35979