Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump moby vendor and dependencies #892

Merged
merged 6 commits into from
Feb 20, 2018

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Feb 20, 2018

- Add API support for SCTP port mapping
- Add canonical import path
- Add `REMOVE` and `ORPHANED` to TaskState
- Fix TLS from environment variables in client
- Introduce NewClientWithOpts func to build custom client easily
- Wrap response errors for container copy methodsto fix error detection using
  `IsErrNotFound` and `IsErrNotImplemented` for `ContainerStatPath`,
  `CopyFromContainer`, and `CopyToContainer` methods.
- Produce errors when empty ids are passed into inspect calls

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- Support parsing SCTP port mapping

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦁

@cpuguy83
Copy link
Collaborator

Looks like CircleCI is having some problems starting (some of) the tests.

@cpuguy83
Copy link
Collaborator

I don't have access to trigger a rebuild in Circle.

@codecov-io
Copy link

codecov-io commented Feb 20, 2018

Codecov Report

Merging #892 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #892   +/-   ##
======================================
  Coverage    53.2%   53.2%           
======================================
  Files         258     258           
  Lines       16338   16338           
======================================
  Hits         8693    8693           
  Misses       7080    7080           
  Partials      565     565

Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdemeester vdemeester merged commit 02e8dc6 into docker:master Feb 20, 2018
@GordonTheTurtle GordonTheTurtle added this to the 18.03.0 milestone Feb 20, 2018
@thaJeztah thaJeztah deleted the bump-moby-vendor branch February 20, 2018 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants