Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass compatibility flag to v2 #21

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

mat007
Copy link
Member

@mat007 mat007 commented Nov 26, 2021

Fixes #15

@ulyssessouza ulyssessouza merged commit abf9d0f into docker:master Nov 29, 2021
@ndeloof
Copy link
Contributor

ndeloof commented Dec 2, 2021

Too late, but a strong 👎 on this.
Many users (including me) use docker-compose as a command and expect a full V2 target. This should not just be considered a "legacy compatibility" mode

@mat007
Copy link
Member Author

mat007 commented Dec 2, 2021

Ah sorry @ndeloof I should have pinged you when creating this PR.

Can you elaborate a bit? If you’re expecting V2, is there any reason you can’t directly invoke docker compose?

@ndeloof
Copy link
Contributor

ndeloof commented Dec 2, 2021

As of 2.0.1 compose v2 is distributed on a few Linux distros (typically: arch) as drop-in replacement for docker-compose
I also have a bunch of scripts here relying on docker-compose but still wanted to use V2.

IMHO compose v2 should not be restricted to "cli plugin" and docker space compose, this is just the new compose.

@mat007
Copy link
Member Author

mat007 commented Dec 3, 2021

But isn’t docker-compose usable as a standalone binary now?
Discussing with @ulyssessouza he mentioned that Arch Linux are actually using the plugin directly as a binary just like that?

@ndeloof
Copy link
Contributor

ndeloof commented Dec 3, 2021

Yes indeed, our released binary can be used both as a CLI plugin or standalone binary as drop in replacement for docker-compose. That's my point: using the latter I expect I can run compose V2 I installed, I'm not in a hidden transition phase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to pass --compatibility-flag
3 participants