-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compose-switch is installed as a Linux "alternative" to docker-compose #4
Conversation
bc29091
to
9607266
Compare
``` | ||
1. rename docker-compose if you already have it installed as `/usr/local/bin/docker-compose` | ||
```console | ||
$ mv /usr/local/bin/docker-compose /usr/local/bin/docker-compose-v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible not to rename it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to define alternative docker-compose
command that will come first in PATH
, and unfortunately /usr/local/bin
comes first (we should not use /usr/local/sbin`)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha, this is not the one from the package, but one that could have been installed by the user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, as documented by https://docs.docker.com/compose/install/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add an example of how to switch in the readme?
9607266
to
cbedee6
Compare
5282363
to
6b45e1d
Compare
6b45e1d
to
7851419
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f2063ab
to
5aff87e
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
5aff87e
to
1840e02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
But how now user switches between V1/V2 on Windows? |
It also doesn't work on every Linux distro, see #10. |
Docker Desktop includes its own flavor of the Compose switch, so you can configure V1 vs V2 on settings. Otherwise, you can just select if docker-compose V1 is first in your PATH. |
Well, I thought the whole point why this project exists was to provide a way to switch between V1 and V2 (it even has switch in its name!). But switch that can no longer switch is kinda... not a switch at all anymore? |
the name might be confusing, but the goal of this project is to make it easy to "switch from V1 to V2" by translating docker-compose V1 command into V2. This never has been intended to offer a "switch" to select V1 or V2 depending on your daily mood. Suggestion to rely on for Linux alternatives was introduced late by a discussion with teammates on Linux packaging, this is not the core of this project. Maybe we should rename as |
you can safely assume |
This PR:
alternatives
see docker/docker-ce-packaging#553 (comment) for context
and https://docker.atlassian.net/browse/IL-584 (internal issue tracker)