-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull existing images to update them to new versions #158
Comments
I've thought about this too. I think my one worry is that if you're using images you've just built/tagged manually, it'll try to pull them and fail. However, I'm not aware of anyone doing that (I mean, that's what |
In my case, we're running Fig on a cloud server, and the actual images are built by developers on their own computers. I don't know if this is the usual case.. |
+1 @kennu not sure if its good or not, but this is what we do too. currently I am managing two almost identical fig files. one with build and one with image. |
+1 |
+1 for Would the maintainers be interested in this if I tried to put something together? |
@bmorton yeah, that'd be fantastic! |
|
Can |
@schainker-digbil I agree that "fig up" should always attempt to create a consistent environment, even if it is slower. Related: #12 |
I can see auto-pull being a problem when:
1 can be worked around by checking for a working connection (or attempting to pull and catching the appropriate error). 2 and 3, I'm less sure about. I don't want to have to wait around to get to work just because someone released a new version of an image I depend on. It's also worth noting that auto-pull would result in different update semantics for |
I concur with @aanand's cache analogy - docker will never retrieve the latest base image unless the cache is invalidated, and as such doesn't create a consistent environment between caches before/after a given image tag. Perhaps |
I definitely would not want auto-pull behaviour. Our CI updates the tags in the registry. In the same way I don't want my git master to auto-pull just because a colleague pushed new code while I'm in the middle of something, I don't want my docker containers to mysteriously change the next time I do |
@aanand: For #2, maybe you could monitor the connection speed while you download and bail out if it's too slow, and then relaunch the "stale" container? For #3, I it depends whether the user cares about a ton of stuff to download or not? In our deployment, we mostly push small changes once the container is up. Good points, though, those last two cases are "non-trivial". @sublimino @d11wtq what about |
I think |
@d11wtq +1 |
Fixes docker#158 Signed-off-by: Luke Amdor <luke.amdor@gmail.com>
Fixes docker#158 Signed-off-by: Luke Amdor <luke.amdor@gmail.com> Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Add runtimeArgs to pass to shim
Apparently there is no way to pull each configured image to update them to latest versions. I frequently do this because I deploy new versions of my apps by pushing new images to a private repository. Currently I have to run "docker pull" manually for each of them.
Could there be a command like:
(If there already is a command for this, I missed it while trying to grep the source code and read the docs.)
The text was updated successfully, but these errors were encountered: