Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update compose examples #1936

Closed
dnephin opened this issue Aug 27, 2015 · 4 comments · Fixed by #2265
Closed

Update compose examples #1936

dnephin opened this issue Aug 27, 2015 · 4 comments · Fixed by #2265
Labels
kind/docs

Comments

@dnephin
Copy link

dnephin commented Aug 27, 2015

I've never tried the example projects, but I've noticed we get a decent number of PRs and issues opened about them (ex: #1843, and many of our oldest PRs).

It may be that we only need to make a couple small changes to smooth out the examples, but I'm opening this issue to track the work.

Related:
@dnephin dnephin mentioned this issue Aug 27, 2015
Closed
@dnephin
Copy link
Author

dnephin commented Aug 27, 2015

From #1843, the django example causes some files to be owned as root (because of the volume).

@dnephin
Copy link
Author

dnephin commented Aug 27, 2015

Another idea is to find a way to be able to execute the code blocks in the docs to verify that the docs are actually correct. I know there are tools to do this, but I'm not sure how difficult it would be to integrate with the rest of our docs build.

@dnephin dnephin mentioned this issue Aug 31, 2015
Closed
@dnephin
Copy link
Author

dnephin commented Aug 31, 2015

#928 is a related ticket which I think has some good points

@dnephin
Copy link
Author

dnephin commented Aug 31, 2015

#1685 calls out an issue with the wordpress example

@dnephin dnephin mentioned this issue Sep 1, 2015
Closed
dnephin added a commit to dnephin/compose that referenced this issue Oct 27, 2015
@dnephin
Fixes docker#1843, docker#1936 - chown files back to host user in dja…
d5f563f 
…ngo example.

Also add a missing 'touch Gemfile.lock' to fix the rails tutorial.

Signed-off-by: Daniel Nephin <dnephin@docker.com>
@dnephin dnephin mentioned this issue Oct 27, 2015
Merged
dnephin added a commit to dnephin/compose that referenced this issue Oct 30, 2015
@dnephin
Fixes docker#1843, docker#1936 - chown files back to host user in dja…
c7d164d 
…ngo example.

Also add a missing 'touch Gemfile.lock' to fix the rails tutorial.

Signed-off-by: Daniel Nephin <dnephin@docker.com>
dnephin added a commit to dnephin/compose that referenced this issue Oct 30, 2015
@dnephin
Fixes docker#1843, docker#1936 - chown files back to host user in dja…
d392f70 
…ngo example.

Also add a missing 'touch Gemfile.lock' to fix the rails tutorial.

Signed-off-by: Daniel Nephin <dnephin@docker.com>
mdaue pushed a commit to mdaue/compose that referenced this issue Nov 29, 2015
@dnephin @mdaue
Fixes docker#1843, docker#1936 - chown files back to host user in dja…
2bfa095 
…ngo example.

Also add a missing 'touch Gemfile.lock' to fix the rails tutorial.

Signed-off-by: Daniel Nephin <dnephin@docker.com>
mdaue pushed a commit to mdaue/compose that referenced this issue Dec 20, 2015
@dnephin @mdaue
Fixes docker#1843, docker#1936 - chown files back to host user in dja…
0a5c51e 
…ngo example.

Also add a missing 'touch Gemfile.lock' to fix the rails tutorial.

Signed-off-by: Daniel Nephin <dnephin@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update tutorials and small fix with rails tutorial dnephin/compose
1 participant
@dnephin