Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve validation schema for list_or_dict fields #2008

Closed
dnephin opened this issue Sep 8, 2015 · 2 comments
Closed

Improve validation schema for list_or_dict fields #2008

dnephin opened this issue Sep 8, 2015 · 2 comments
Labels
area/config

Comments

@dnephin
Copy link

dnephin commented Sep 8, 2015

Right now extra_hosts and labels use "one of: object or array", but no validation is done on the contents of the object.

I think this can be improved by creating a schema for the object that uses patternProperties, so that it will fail if someone uses nested objects, or arrays within the object.

{
  "type": "object",
  "patternProperties": {"type": "string"},
}
@mnowster mnowster mentioned this issue Sep 8, 2015
Merged
@dnephin
Copy link
Author

dnephin commented Sep 8, 2015

Apparently you've already have a fix for this in #2000!

@dnephin dnephin changed the title Improve validation schema for environment field Improve validation schema for list_or_dict fields Sep 8, 2015
@dnephin
Copy link
Author

dnephin commented Sep 8, 2015

I've updated this issue to be about the list_or_dict schema, since it has the same issue, and isn't fixed by #2000

dnephin added a commit to dnephin/compose that referenced this issue Nov 13, 2015
@dnephin
Fixes docker#2008 - re-use list_or_dict schema for all the types
47369c1 
At the same time, moves extra_hosts validation to the config module.

Signed-off-by: Daniel Nephin <dnephin@docker.com>
dnephin added a commit to dnephin/compose that referenced this issue Nov 17, 2015
@dnephin
Fixes docker#2008 - re-use list_or_dict schema for all the types
5a5e54a 
At the same time, moves extra_hosts validation to the config module.

Signed-off-by: Daniel Nephin <dnephin@docker.com>
@dnephin dnephin mentioned this issue Nov 17, 2015
Merged
dnephin added a commit to dnephin/compose that referenced this issue Nov 17, 2015
@dnephin
Fixes docker#2008 - re-use list_or_dict schema for all the types
cfb0b93 
At the same time, moves extra_hosts validation to the config module.

Signed-off-by: Daniel Nephin <dnephin@docker.com>
dnephin added a commit to dnephin/compose that referenced this issue Nov 23, 2015
@dnephin
Fixes docker#2008 - re-use list_or_dict schema for all the types
58efcc8 
At the same time, moves extra_hosts validation to the config module.

Signed-off-by: Daniel Nephin <dnephin@docker.com>
dnephin added a commit to dnephin/compose that referenced this issue Dec 3, 2015
@dnephin
Fixes docker#2008 - re-use list_or_dict schema for all the types
5d39813 
At the same time, moves extra_hosts validation to the config module.

Signed-off-by: Daniel Nephin <dnephin@docker.com>
mdaue pushed a commit to mdaue/compose that referenced this issue Dec 20, 2015
@dnephin @mdaue
Fixes docker#2008 - re-use list_or_dict schema for all the types
a709e2d 
At the same time, moves extra_hosts validation to the config module.

Signed-off-by: Daniel Nephin <dnephin@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/config
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dnephin