Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flake8 error on master branch, file compose/bundle.py #5298

Closed
garribas opened this issue Oct 23, 2017 · 2 comments
Closed

flake8 error on master branch, file compose/bundle.py #5298

garribas opened this issue Oct 23, 2017 · 2 comments

Comments

@garribas
Copy link

When trying to run the test suite on master branch the pre-commit hook fails with an flake8 error:

$ script/test/default 
Flake8...................................................................Failed
hookid: flake8

compose/bundle.py:124:5: E722 do not use bare except'
garribas added a commit to garribas/compose that referenced this issue Oct 23, 2017
@garribas
flake8 error on master branch (fixes docker#5298)
a7a54a0 
Signed-off-by: Guillermo Arribas <garribas@gmail.com>
@shin-
Copy link

shin- commented Oct 23, 2017

I feel like this is not the first time a Flake8 update adds new errors ; we should probably pin the version to avoid this going forward.

@shin- shin- closed this as completed in 2e81e6c Oct 23, 2017
@garribas
Copy link
Author

@shin- the root cause of this is that the "pre-commit-hooks" doesn't pin any of its dependencies:
https://github.com/pre-commit/pre-commit-hooks/blob/master/requirements-dev.txt

@shin- shin- mentioned this issue Oct 23, 2017
Merged
shin- pushed a commit that referenced this issue Nov 1, 2017
@garribas @shin-
flake8 error on master branch (fixes #5298)
0847f8e 
Signed-off-by: Guillermo Arribas <garribas@gmail.com>
shin- pushed a commit that referenced this issue Dec 6, 2017
@garribas @shin-
flake8 error on master branch (fixes #5298)
4c10e57 
Signed-off-by: Guillermo Arribas <garribas@gmail.com>
ndeloof pushed a commit to ndeloof/compose that referenced this issue Jan 30, 2023
@milas
build: ensure file handles properly closed (docker#5298)
81f8af0 
I've been running the test suite (`./internal/engine` in particular)
with `-count X` a lot recently to catch timing-related test failures.

After running enough times, the tests start failing due to too many
open files, so I did an audit and found a few places where files or
readers weren't always being closed.
ndeloof pushed a commit to ndeloof/compose that referenced this issue Jan 30, 2023
@milas @ndeloof
build: ensure file handles properly closed (docker#5298)
d56e4be 
I've been running the test suite (`./internal/engine` in particular)
with `-count X` a lot recently to catch timing-related test failures.

After running enough times, the tests start failing due to too many
open files, so I did an audit and found a few places where files or
readers weren't always being closed.
ndeloof pushed a commit to ndeloof/compose that referenced this issue Jan 31, 2023
@milas @ndeloof
build: ensure file handles properly closed (docker#5298)
c694c6b 
I've been running the test suite (`./internal/engine` in particular)
with `-count X` a lot recently to catch timing-related test failures.

After running enough times, the tests start failing due to too many
open files, so I did an audit and found a few places where files or
readers weren't always being closed.
ndeloof pushed a commit to ndeloof/compose that referenced this issue Feb 1, 2023
@milas @ndeloof
build: ensure file handles properly closed (docker#5298)
e11c9c0 
I've been running the test suite (`./internal/engine` in particular)
with `-count X` a lot recently to catch timing-related test failures.

After running enough times, the tests start failing due to too many
open files, so I did an audit and found a few places where files or
readers weren't always being closed.
ndeloof pushed a commit that referenced this issue Feb 2, 2023
@milas @ndeloof
build: ensure file handles properly closed (#5298)
6fc0b6f 
I've been running the test suite (`./internal/engine` in particular)
with `-count X` a lot recently to catch timing-related test failures.

After running enough times, the tests start failing due to too many
open files, so I did an audit and found a few places where files or
readers weren't always being closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garribas @shin-