Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fig.yml support for --add-host? #597

Closed
coderlol opened this issue Oct 30, 2014 · 6 comments
Closed

fig.yml support for --add-host? #597

coderlol opened this issue Oct 30, 2014 · 6 comments

Comments

@coderlol
Copy link

Any chance fig.yml can support the docker run option --add-host?

@elephantum
Copy link

+1

@emslade
Copy link

emslade commented Nov 14, 2014

I had a go at implementing this. The docker-py client doesn't support the option either, so I had to add the support for it there too. I've submitted a PR (docker/docker-py#400) to docker-py for this functionality. The main change I'll submit as a PR to this repo will be emslade@d069792 but obviously we'll need to wait for the change to docker-py first.

@manolitto
Copy link

+1

@ddossot
Copy link

ddossot commented Nov 21, 2014

That would be super convenient for providing the host IP 👍

Actually, maybe fig should always use --add-host on start to provide the host IP using a well-known entry in /etc/hosts plus allow adding extra hosts entries.

@Stono
Copy link

Stono commented Dec 13, 2014

Totallly want this please!

@bfirsh
Copy link

bfirsh commented Dec 23, 2014

Closed in favour of #754. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants