Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up: teardown when command context is cancelled #11292

Merged
merged 2 commits into from
Jan 2, 2024

up: gracefully teardown when command ctx cancelled

dcbf005
Select commit
Loading
Failed to load commit list.
Merged

Up: teardown when command context is cancelled #11292

up: gracefully teardown when command ctx cancelled
dcbf005
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 23, 2023 in 0s

56.22% (-0.15%) compared to 17da54d

View this Pull Request on Codecov

56.22% (-0.15%) compared to 17da54d

Details

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (17da54d) 56.36% compared to head (dcbf005) 56.22%.
Report is 11 commits behind head on main.

Files Patch % Lines
pkg/compose/up.go 84.21% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11292      +/-   ##
==========================================
- Coverage   56.36%   56.22%   -0.15%     
==========================================
  Files         134      135       +1     
  Lines       11615    11659      +44     
==========================================
+ Hits         6547     6555       +8     
- Misses       4421     4451      +30     
- Partials      647      653       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.