use listeners to collect include metrics #11503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
includes_metric
branch
from
ff7882e to
28254d9
Compare
ndeloof
commented
Feb 15, 2024
| @@ -35,8 +33,12 @@ import ( | |||
| // SpanOptions is a small helper type to make it easy to share the options helpers between | |||
| // downstream functions that accept slices of trace.SpanStartOption and trace.EventOption. | |||
| type SpanOptions []trace.SpanStartEventOption | |||
|
|
|||
| type MetricsKey struct{} | |||
There was a problem hiding this comment.
adding a slice attribute made Metrics non-comparable, so I introduced a dedicated context key struct
ndeloof
requested review from
a team,
glours,
milas and
jhrotko
and removed request for
a team
ndeloof
commented
Feb 15, 2024
ndeloof
force-pushed
the
includes_metric
branch
from
28254d9 to
8479c36
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11503 +/- ##
==========================================
+ Coverage 58.33% 58.41% +0.07%
==========================================
Files 134 134
Lines 11521 11520 -1
==========================================
+ Hits 6721 6729 +8
+ Misses 4137 4131 -6
+ Partials 663 660 -3 ☔ View full report in Codecov by Sentry. |
ndeloof
force-pushed
the
includes_metric
branch
from
8479c36 to
f143937
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
includes_metric
branch
from
f143937 to
0aad322
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
collect
includesusage relying on compose-go listenerRelated issue
require compose-spec/compose-go#576
(not mandatory) A picture of a cute animal, if possible in relation to what you did