Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get log to manage attach #11542

Merged
merged 1 commit into from
Feb 27, 2024
Merged

get log to manage attach #11542

merged 1 commit into from
Feb 27, 2024

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Feb 22, 2024

if compose file is configured not to attach to a service, logs command should not include this service

closes #11529

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (a722441) 58.26% compared to head (58ec0e9) 58.31%.

Files Patch % Lines
cmd/compose/logs.go 0.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11542      +/-   ##
==========================================
+ Coverage   58.26%   58.31%   +0.04%     
==========================================
  Files         135      135              
  Lines       11550    11555       +5     
==========================================
+ Hits         6730     6738       +8     
+ Misses       4155     4153       -2     
+ Partials      665      664       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhrotko jhrotko merged commit e2762b1 into docker:main Feb 27, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] inconsistent handling for the attach property between docker compose up and logs
3 participants