Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid duplicated "xx exited with code 0" message #11562

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Feb 29, 2024

What I did
As up --watch recreates a container, I noticed we get duplicated message "xx-1 exited with code 0". This is caused by both stop and die event being received as we update service container
Also restore build output for the standalone compose watch command

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof requested review from a team, glours, milas and jhrotko and removed request for a team February 29, 2024 08:20
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 58.22%. Comparing base (8ab8df8) to head (3b654dc).

Files Patch % Lines
pkg/compose/up.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11562      +/-   ##
==========================================
+ Coverage   58.20%   58.22%   +0.01%     
==========================================
  Files         135      135              
  Lines       11614    11617       +3     
==========================================
+ Hits         6760     6764       +4     
  Misses       4182     4182              
+ Partials      672      671       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndeloof ndeloof merged commit e99b8ac into docker:main Feb 29, 2024
28 checks passed
@ndeloof ndeloof deleted the watch_more branch February 29, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants