Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bake #12507

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Fix bake #12507

merged 1 commit into from
Jan 29, 2025

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Jan 29, 2025

What I did
fix build delegation to bake for corner-cases detected on #12501

ability to build service in dependency order is preserved when --compatibility is set, as it would be better imho to have explicit support for this by #12485

see tests running on #12501 (some will need to be fixed as output isn't the same vs buildkit)

@ndeloof ndeloof requested a review from a team as a code owner January 29, 2025 07:54
@ndeloof ndeloof requested a review from glours January 29, 2025 07:54
@ndeloof ndeloof force-pushed the fix_bake branch 2 times, most recently from 404ce4d to 274374f Compare January 29, 2025 08:17
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me 👍

@glours glours merged commit 4b70ff0 into docker:main Jan 29, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants