Added devices config handling and device HostConfig handling #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a good start. I believe we also need to update |
|
I've updated the pull request. |
| @@ -342,6 +342,15 @@ dns_search: | |||
| - dc2.example.com | |||
| ``` | |||
|
|
|||
| ### devices | |||
|
|
|||
| Devices option. List of device mappings. Uses the same format as the --device docker client create option. | |||
There was a problem hiding this comment.
- First sentence is unnecessary
--deviceshould be in backticks- Wrap to 80 chars please!
|
Thanks! For the sake of consistency, we should support a mapping as well as a list. Is that supported? If so, it should be documented. |
DanElbert
force-pushed
the
754-device_option
branch
from
3ea10e7 to
53a08c0
Compare
I retract this, as I was thinking about environment variables. We don't support YAML mappings for volumes. Sorry for the noise. This looks good - just needs squashing to a single commit. |
|
Thanks for the feedback. I was just going to ask about the mapping. :) |
Signed-off-by: Dan Elbert <dan.elbert@gmail.com>
DanElbert
force-pushed
the
754-device_option
branch
from
53a08c0 to
df87bd9
Compare
|
All squashed. Let me know if I missed anything else. |
|
LGTM |
1 similar comment
|
LGTM |
dnephin
added a commit
that referenced
this pull request
May 11, 2015
Added devices config handling and device HostConfig handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm new to contributing to compose, but this is a stab at adding the device option to the yml config, as per issue #754.