Modified scale awareness from exception to warning #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
force-pushed
the
changing-scale-to-warning
branch
from
6d5ff62 to
2538283
Compare
|
I think this is a good idea. I'll defer to others about the text of the warning. |
| raise CannotBeScaledError() | ||
| log.warn('Service %s only specifies a port on the host. If multiple ' | ||
| 'containers for this service are created on a single host, ' | ||
| 'the port will clash.' % self.name) |
There was a problem hiding this comment.
Pretty clear warning, but I don't think we need "only".
There was a problem hiding this comment.
Oh, you're right, makes more sense without the "only"
Signed-off-by: André Martins <martins@noironetworks.com>
aanm
force-pushed
the
changing-scale-to-warning
branch
from
2538283 to
ae63d35
Compare
|
LGTM |
1 similar comment
|
LGTM |
aanand
added a commit
that referenced
this pull request
Jun 4, 2015
Modified scale awareness from exception to warning
|
ping @bfirsh - reckon we could consider this a "bug fix" and include it in 1.3? |
|
👍 |
|
Nice. Let's do another RC with this fix then (after a few days, just in case any more issues crop up). |
|
Thank you!
|
aanand
added a commit
to aanand/fig
that referenced
this pull request
Jun 12, 2015
…arning Modified scale awareness from exception to warning (cherry picked from commit 7d2a894) Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
aanand
added a commit
to aanand/fig
that referenced
this pull request
Jun 15, 2015
…arning Modified scale awareness from exception to warning (cherry picked from commit 7d2a894) Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
|
It should be possible to use scale and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It starts not making sense only use docker-compose on a single host environment. I'm proposing removing the scale awareness of port collision from exception to a warning.
Fixes: #1378
Signed-off-by: André Martins martins@noironetworks.com