Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hint: Enclose bool variables in quotes when using dictionary #1976

Closed
wants to merge 1 commit into from
Closed

Add Hint: Enclose bool variables in quotes when using dictionary #1976

wants to merge 1 commit into from

Conversation

marb-dev
Copy link

@marb-dev marb-dev commented Sep 3, 2015

Environment variables like true and false should be enclosed in quotes when using a dictionary; otherwise, their value will be parsed into True or False in the container, which makes them harder to be used within scripts.
Covers #1788

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "hint-quote-vars" git@github.com:marb-dev/compose.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

@aanand
Copy link

aanand commented Sep 4, 2015

It absolutely sucks that Compose does this. Instead of telling users to work around it, we should treat it as a bug and fix it. There's already an issue for that - #1788 - and we're making it a priority for Compose 1.5.

As such, I'm going to close this PR. Thank you for contributing!

@aanand aanand closed this Sep 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants