Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to set custom tag, somewhat addresses #213 #441

Closed
wants to merge 1 commit into from

Conversation

parisholley
Copy link

I have a repo that has all my docker images, prefer not to have to push them to a repo in order to reference images by name. I use fig.yml to build all images locally, which can than be reused through DockerFiles, etc.

@dnephin
Copy link

dnephin commented Aug 25, 2014

Some things you'll probably be asked for:

  • the build is failing because of a flake8 check, you'll need to fix the whitespace
  • commit message should include a signoff, see Contributing
  • docs should probably be updated to include this

@dnephin
Copy link

dnephin commented Aug 30, 2014

I think another issue may be that when you change the tag name it may have trouble finding the containers for this image, because it assumes the naming convention is always project_service_index.

I think leaving that assumption as-is should be fine. Instead I think we can docker tag for each tag name when the image is built.

@dnephin
Copy link

dnephin commented Aug 30, 2014

#457 should add full support

@dnephin
Copy link

dnephin commented Jun 4, 2015

#1066 will be in the next release, which will let us do #652

Closing this PR in favor of the explicit naming proposed in those tickets

@dnephin dnephin closed this Jun 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants