Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for expanded port syntax in 3.1 format #4541

Merged
merged 1 commit into from
Mar 7, 2017
Merged

Add support for expanded port syntax in 3.1 format #4541

merged 1 commit into from
Mar 7, 2017

Conversation

shin-
Copy link

@shin- shin- commented Feb 28, 2017 •
edited
Loading

  • Needs tests

Fixes #4502

@shin- shin- force-pushed the 4502-expanded-port-syntax branch 3 times, most recently from dbc6f75 to f108d40 Compare March 1, 2017 01:51
@shin- shin- requested a review from dnephin March 1, 2017 01:53
@shin-
Add support for expanded port syntax in 3.1 format
11788ef 
Signed-off-by: Joffrey F <joffrey@docker.com>
@shin- shin- force-pushed the 4502-expanded-port-syntax branch from f108d40 to 11788ef Compare March 1, 2017 20:11
dnephin
dnephin approved these changes Mar 1, 2017
View reviewed changes
Copy link

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for adding the secrets serializer, I missed that

@shin- shin- added this to the 1.12.0 milestone Mar 1, 2017
@shin- shin- merged commit 0167aba into docker:master Mar 7, 2017
@shin- shin- deleted the 4502-expanded-port-syntax branch March 23, 2017 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnephin dnephin dnephin approved these changes

Assignees
No one assigned
Labels
area/config
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shin- @dnephin