Fix test failures on docker 1.1.2 #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
force-pushed
the
fix_tests_for_docker_1.1
branch
2 times, most recently
from
f9ce9d4 to
306ff8b
Compare
|
Earlier diffs had some bugs in |
|
Looks good, but needs a rebase! |
…t() in every property, and provides a nicer interface for querying container data. Signed-off-by: Daniel Nephin <dnephin@gmail.com>
…e_container() explaining what it does. Signed-off-by: Daniel Nephin <dnephin@gmail.com>
dnephin
force-pushed
the
fix_tests_for_docker_1.1
branch
from
306ff8b to
71e7103
Compare
|
Rebased |
|
LGTM |
aanand
added a commit
that referenced
this pull request
Oct 1, 2014
Fix test failures on docker 1.1.2
yuval-k
pushed a commit
to yuval-k/compose
that referenced
this pull request
Apr 10, 2015
Fix test failures on docker 1.1.2 Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some background in #328, but I've seen the integration test suite failing on two tests (
test_project_up_recreates_containers,test_recreate_containers) for a while now, ever since I upgraded to docker 1.1.x.Changing the path from
/var/db/to/etc/fixes this, which I think is an improvement for now (so that the tests are still useful for catching other issues).The second part of this change is to add a
container.get(). This uses dotted notation and performs aninspect_if_not_inspected()on each call, removing the need to call it everywhere, and providing a nicer interface for fetching other container data if there isn't an existing property for it.