Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopting background before stop and kill #4634

Closed
wants to merge 2 commits into from
Closed

Adopting background before stop and kill #4634

wants to merge 2 commits into from

Conversation

rawkode
Copy link

@rawkode rawkode commented Mar 18, 2017

Adopting 'background' first on Cntrl-C and allowing second and third taps to be stop and kill

Would fix #4560, though I am aware this changes current behaviour and perhaps should be tackled a different way.

Signed-off-by: David McKay david@rawkode.com

…taps to be stop and kill

Signed-off-by: David McKay <david@rawkode.com>
@rawkode
Copy link
Author

rawkode commented Mar 18, 2017

Although I said this "changes current behaviour" ... it is a "soft" change and an additional press would replicate original behaviour.

Thoughts, @shin- ?

Signed-off-by: David McKay <david@rawkode.com>
@shin-
Copy link

shin- commented Mar 20, 2017

Thanks for taking the time to submit this!

From a user experience standpoint, this seems like a net loss to me. It means pressing Ctrl-C now do 3 different things depending on how many times you press it, and one of those things is significantly different from the 2 other.

Also, as I mentioned in #3936, this can already be done with some UNIX magic. As a result, I would be happy to merge support for something like the Ctrl-P Ctrl-C combination (since it seems to be what the engine uses for attached containers), but anything short of that seems too subpar to justify.

@rawkode
Copy link
Author

rawkode commented Mar 21, 2017

Perhaps it's just my opinion, but control sequences, like C-P C-Q, are so esoteric.

Perhaps on C-c, we can prompt for input: Background, Stop or Kill? with a default after a few seconds to normal behaviour?

@rawkode
Copy link
Author

rawkode commented Mar 21, 2017

Or I could let my shell handle it I guess 😂

@shin-
Copy link

shin- commented Mar 21, 2017

Perhaps it's just my opinion, but control sequences, like C-P C-Q, are so esoteric.

You won't hear me disagree on that one. But it would at least be somewhat consistent with Engine, so there's possible transfer of knowledge there.

Perhaps on C-c, we can prompt for input: Background, Stop or Kill? with a default after a few seconds to normal behaviour?

Well, do you agree with me that this is still a straight-up worse UX for people who want to stop/kill, and only marginally better for people who want to detach? The tradeoff just doesn't seem worthwhile to me.

@rawkode
Copy link
Author

rawkode commented Mar 21, 2017

Yeah, I'm getting there 👍

@rawkode rawkode closed this Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

key sequence to detach from docker-compose up
2 participants