Adopting background before stop and kill

[rawkode]

Adopting 'background' first on Cntrl-C and allowing second and third taps to be stop and kill

Would fix #4560, though I am aware this changes current behaviour and perhaps should be tackled a different way.

Signed-off-by: David McKay david@rawkode.com

[rawkode]

Although I said this "changes current behaviour" ... it is a "soft" change and an additional press would replicate original behaviour.

Thoughts, @shin- ?

[shin-]

Thanks for taking the time to submit this!

From a user experience standpoint, this seems like a net loss to me. It means pressing Ctrl-C now do 3 different things depending on how many times you press it, and one of those things is significantly different from the 2 other.

Also, as I mentioned in #3936, this can already be done with some UNIX magic. As a result, I would be happy to merge support for something like the Ctrl-P Ctrl-C combination (since it seems to be what the engine uses for attached containers), but anything short of that seems too subpar to justify.

[rawkode]

Perhaps it's just my opinion, but control sequences, like C-P C-Q, are so esoteric.

Perhaps on C-c, we can prompt for input: Background, Stop or Kill? with a default after a few seconds to normal behaviour?

[rawkode]

Or I could let my shell handle it I guess 😂

[shin-]

Perhaps it's just my opinion, but control sequences, like C-P C-Q, are so esoteric.

You won't hear me disagree on that one. But it would at least be somewhat consistent with Engine, so there's possible transfer of knowledge there.

Perhaps on C-c, we can prompt for input: Background, Stop or Kill? with a default after a few seconds to normal behaviour?

Well, do you agree with me that this is still a straight-up worse UX for people who want to stop/kill, and only marginally better for people who want to detach? The tradeoff just doesn't seem worthwhile to me.

[rawkode]

Yeah, I'm getting there 👍