Use upstream dockerpty 0.3.2 #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine in that it doesn't seem to break anything, but #568 is still happening for me. |
|
Sorry, yes, #561. |
|
Ya... I guess I didn't revert enough. Apparently it's not related to the select() change |
|
Sorry about that, I put up another PR at d11wtq/dockerpty/pull/23 which seems to actually resolve it |
|
Pending release of dockerpty with d11wtq/dockerpty#24 |
This reverts commit 60411e9. Closes docker#556 Signed-off-by: Ben Firshman <ben@firshman.co.uk> Conflicts: requirements.txt setup.py
Patch from d11wtq/dockerpty#24 Signed-off-by: Ben Firshman <ben@firshman.co.uk>
bfirsh
force-pushed
the
use-upstream-dockerpty
branch
from
6412e1b
to
8773f51
Compare
|
dockerpty has been released so this is ready to merge. |
|
LGTM |
|
Thanks for applying my patch! I've still travelling and haven't had time to submit the pr |
yuval-k
pushed a commit
to yuval-k/compose
that referenced
this pull request
Apr 10, 2015
Use upstream dockerpty 0.3.2 Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 60411e9.
Closes #556
Signed-off-by: Ben Firshman ben@firshman.co.uk
Conflicts:
requirements.txt
setup.py