Support multiple port bindings for same internal port #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Burkett <burkett.andrew@gmail.com>
|
Nice, this looks good. Thanks for the contribution! Could you write a unit test for it as well? It will probably be easier to test if it's extracted into a new function, maybe |
drewkett
changed the title
Signed-off-by: Andrew Burkett <burkett.andrew@gmail.com>
drewkett
force-pushed
the
multiple_port_mappings
branch
from
a4e3ce3
to
4f6d028
Compare
|
LGTM |
|
LGTM, thanks for the contribution! |
dnephin
added a commit
that referenced
this pull request
Nov 7, 2014
Support multiple port bindings for same internal port
yuval-k
pushed a commit
to yuval-k/compose
that referenced
this pull request
Apr 10, 2015
Support multiple port bindings for same internal port Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If multiple port mappings use the same internal port of a service, only the last one is currently used. This fixes it by mapping the internal ports to lists.
Signed-off-by: Andrew Burkett burkett.andrew@gmail.com