Added support of cpuset and memswap_limit options in fig.yml. #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arie Bro <ariebro@gmail.com>
|
The tests that fail are the same from #659. I would wait until tests pass there (and later here) before merging this PR. |
arieb
changed the title
|
Yup, I added a suggestion in #659 about how I think we can get the tests working again. |
5 tasks
|
These are both supported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for cpuset and memswap_limit options. unfortunately cpuset support was only added on docker-py 0.6, so i updated the setup.py and requirements.txt to use 0.6 (i saw there is already an open PR on this #659 ).