Update dind setup for tests #8081
Conversation
aiordache
requested review from
ndeloof,
rumpl and
ulyssessouza
as code owners
aiordache
force-pushed
the
update_Jenkins
branch
from
e4bfa85 to
6fa0675
Compare
Jenkinsfile
Outdated
| @@ -99,6 +99,8 @@ def runTests(dockerVersion, pythonVersion, baseImage) { | |||
| --privileged \\ | |||
| --volume="\$(pwd)/.git:/code/.git" \\ | |||
| --volume="/var/run/docker.sock:/var/run/docker.sock" \\ | |||
| --volume="\$(pwd)/.docker/config.json:/code/.docker/config.json" \\ | |||
There was a problem hiding this comment.
I think it needs to be in the home directory, so I assume it is /root/.docker/config.json in the container. On the host probably in $HOME.
There was a problem hiding this comment.
Looks like script/test/all uses ~/.docker/ ..., which should also work
There was a problem hiding this comment.
(for the "host" side that is 😅)
| @@ -99,6 +99,8 @@ def runTests(dockerVersion, pythonVersion, baseImage) { | |||
| --privileged \\ | |||
There was a problem hiding this comment.
Do we actually need --privileged for this container? I see it bind-mounts docker.sock, which means that all docker commands will actually run against the docker daemon running on the host (not a dockerd daemon running inside the container (which would require privileged)
There was a problem hiding this comment.
Actually wondering if we need a container here at all, because it's running a container, just to run a script, that uses the docker CLI inside the container to start new containers on the host 🤔
aiordache
force-pushed
the
update_Jenkins
branch
from
b701614 to
c5f70f2
Compare
Signed-off-by: aiordache <anca.iordache@docker.com>
aiordache
force-pushed
the
update_Jenkins
branch
from
c5f70f2 to
eaee62e
Compare
|
Also opened docker-library/docker#295 for discussion If I find some time, I may have a look at #8081 (comment) |
Update Jenkins files and scripts:
.docker/configfor authenticating pulls in dind containersdockerswarm/dindwithdocker:<version>-dind