Test for preservation of volumes declared in images #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 20, 2015
Merged
|
LGTM once rebased with #863 (and the test passes) |
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
aanand
force-pushed
the
test-image-volumes
branch
from
425a93f to
17a8a7b
Compare
aanand
changed the title
|
Rebased and tests pass. |
aanand
added a commit
that referenced
this pull request
Jan 20, 2015
Test for preservation of volumes declared in images
yuval-k
pushed a commit
to yuval-k/compose
that referenced
this pull request
Apr 10, 2015
Test for preservation of volumes declared in images Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test succeeds against 72095f5 (i.e. before the merge of #711). We weren't testing this case before.