Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only remove volumes set by compose file #9074

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Jan 3, 2022

What I did
Only remove volumes set by compose file
As no compose file is set (down -p name) use volume labels to rebuild the project model

Related issue
close #8895

(not mandatory) A picture of a cute animal, if possible in relation with what you did

@ndeloof ndeloof force-pushed the down_volumes branch 4 times, most recently from e25ae54 to 624eb79 Compare January 5, 2022 07:42
@mr-karan
Copy link

mr-karan commented Jan 7, 2022

+1 can this be prioritized? This looks an important critical bug that must be addressed ASAP.

@ndeloof ndeloof force-pushed the down_volumes branch 3 times, most recently from 735f9f7 to e211712 Compare January 20, 2022 12:22
@ndeloof ndeloof requested a review from ulyssessouza January 20, 2022 13:24
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ulyssessouza ulyssessouza merged commit bfd7428 into docker:v2 Jan 21, 2022
@ndeloof ndeloof deleted the down_volumes branch December 20, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker compose (v2) down -v removes volumes not mentioned in the docker-compose file
3 participants