use docker/cli RunExec and RunStart to handle all the interactive/tty/* terminal logic #9258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
RunExec
branch
4 times, most recently
from
02cb5ac to
7d20687
Compare
rumpl
approved these changes
Mar 15, 2022
glours
approved these changes
Mar 15, 2022
ndeloof
force-pushed
the
RunExec
branch
4 times, most recently
from
89a9a70 to
a5373fd
Compare
|
There's something weird with this one: test gets an empty stdout, while running same command works. I don't get it |
…/* terminal logic Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Does it need something like https://github.com/creack/pty to have a TTY in the test? See, e.g. https://github.com/moby/moby/blob/a6919e12b103aab6eb95a67450b2a487bfec1097/integration-cli/docker_cli_attach_unix_test.go#L27-L35 |
|
ok, I eventually remembered the initial intent was to restore TTY auto-detection. Went to far into dependent changes :P |
ndeloof
force-pushed
the
RunExec
branch
2 times, most recently
from
bd0eea6 to
a2ae4fe
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
This was referenced Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
dropped all the interactive run/exec logic by leveraging RunExec/RunStart from docker/cli
Using this battle-tested code will make compose way more robust than our attempts to re-implement all corner cases
tested to confirm we don't resurect #8908